Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Unsubscribe from observable subscription #620

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix(editor): Unsubscribe from observable subscription #620

merged 1 commit into from
Sep 18, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

In this PR (#615) I added a subscription to Observables without unsubscribing. This will be fixed in this PR.

@github-actions
Copy link
Contributor

Affected libs: ``,
Affected apps: metadata-editor,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

jahow
jahow approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! FYI you can group subscriptions together using subscription.add(), see https://rxjs.dev/guide/subscription

Then you only have to call subscription.unsubscribe() once :)

@Angi-Kinas Angi-Kinas merged commit bfd28df into main Sep 18, 2023
5 checks passed
@Angi-Kinas Angi-Kinas deleted the ME/fix-filter-by-current-org branch September 18, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Angi-Kinas @jahow